profiler: declare missing printErr
#13590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`v8/tools/tickprocessor.js` assumes presence of global `printErr`, which is defined in `d8`.
|
cc @nodejs/collaborators |
|
cc @nodejs/v8 |
refack
approved these changes
Jun 9, 2017
|
@indutny any way to regression test this? (point me in the right direction I'll write the test)? |
No need === release test-tick-processor-unknown ===
Path: tick-processor/test-tick-processor-unknown
undefined:2649
printErr(str);
^
ReferenceError: printErr is not defined
at TickProcessor.printError (eval at <anonymous> (internal/v8_prof_processor.js:32:1), <anonymous>:2649:3)
at TickProcessor.LogReader.processLog_ (eval at <anonymous> (internal/v8_prof_processor.js:32:1), <anonymous>:2409:12)
at TickProcessor.LogReader.processLogLine (eval at <anonymous> (internal/v8_prof_processor.js:32:1), <anonymous>:2292:10)
at TickProcessor.processLogFile (eval at <anonymous> (internal/v8_prof_processor.js:32:1), <anonymous>:2677:10)
at eval (eval at <anonymous> (internal/v8_prof_processor.js:32:1), <anonymous>:3844:15)
at eval (eval at <anonymous> (internal/v8_prof_processor.js:32:1), <anonymous>:3848:3)
at internal/v8_prof_processor.js:32:1
at NativeModule.compile (bootstrap_node.js:563:7)
at Function.NativeModule.require (bootstrap_node.js:506:18)
at startup (bootstrap_node.js:116:20)
undefined:2649
printErr(str);
^ |
|
@refack yeah. |
addaleax
approved these changes
Jun 9, 2017
|
Quick ci https://ci.nodejs.org/job/node-stress-single-test/1290/nodes=rhel72-s390x |
cjihrig
approved these changes
Jun 9, 2017
tniessen
approved these changes
Jun 10, 2017
|
Landed in 27cc30a |
addaleax
pushed a commit
that referenced
this pull request
Jun 12, 2017
`v8/tools/tickprocessor.js` assumes presence of global `printErr`, which is defined in `d8`. PR-URL: #13590 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
pushed a commit
that referenced
this pull request
Jun 12, 2017
`v8/tools/tickprocessor.js` assumes presence of global `printErr`, which is defined in `d8`. PR-URL: #13590 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
`v8/tools/tickprocessor.js` assumes presence of global `printErr`, which is defined in `d8`. PR-URL: #13590 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
landed on v6.x. Let me know if it should be backed out |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
profiler?
v8/tools/tickprocessor.jsassumes presence of globalprintErr, whichis defined in
d8.