-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: move common.PORT debug tests to sequential #13592
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interested to hear any other method of solving this. I don't think we need to worry too much about these, they'll go away when 6.x goes away. Just trying to avoid any more flakes in CI. Failures that prompted this:
|
Trott
approved these changes
Jun 10, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lpinca
approved these changes
Jun 10, 2017
They tend to hang if they happen to run in parallel with another test that uses common.PORT. PR-URL: nodejs#13592 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn
added a commit
to gibfahn/node
that referenced
this pull request
Jun 17, 2017
They tend to hang if they happen to run in parallel with another test that uses common.PORT. PR-URL: nodejs#13592 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Landed in 7a22964 |
gibfahn
added a commit
that referenced
this pull request
Jun 20, 2017
They tend to hang if they happen to run in parallel with another test that uses common.PORT. PR-URL: #13592 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
They tend to hang if they happen to run in parallel with another test that uses common.PORT. PR-URL: #13592 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs
added a commit
to BethGriggs/node
that referenced
this pull request
Mar 1, 2018
Remove 'flaky' in parallel.status for test-debug-signal-cluster as the test was moved to sequential. Refs: nodejs#13592
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
Remove 'flaky' in parallel.status for test-debug-signal-cluster as the test was moved to sequential. Refs: #13592 PR-URL: #19069 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2018
Remove 'flaky' in parallel.status for test-debug-signal-cluster as the test was moved to sequential. Refs: #13592 PR-URL: #19069 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2018
Remove 'flaky' in parallel.status for test-debug-signal-cluster as the test was moved to sequential. Refs: #13592 PR-URL: #19069 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They tend to hang if they happen to run in parallel with another test that uses common.PORT.
I missed these when looking at #13580, looks like two of these tests were competing with each other in the last run I did.
I've done a diff against the list in #12376, and these are the parallel debugger tests that contain
common.PORT
and are no longer in master:grep results:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test