Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add crypto check to test-tls-wrap-econnreset #13691

Closed

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jun 15, 2017

Currently, there are a few test-tls-wrap-econnreset test that fail when
Node is configured --without-ssl:

Error: Node.js is not compiled with openssl crypto support

This commit adds crypto checks and skips these tests if no crypto
support unavailable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Currently, there are a few test-tls-wrap-econnreset test that fail when
Node is configured --without-ssl:
Error: Node.js is not compiled with openssl crypto support

This commit adds crypto checks and skips these tests if no crypto
support unavailable.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 15, 2017
@danbev
Copy link
Contributor Author

danbev commented Jun 15, 2017

@hiroppy hiroppy added the tls Issues and PRs related to the tls subsystem. label Jun 15, 2017
@gibfahn
Copy link
Member

gibfahn commented Jun 15, 2017

@danbev is there a lint rule we could add for this? Something that says that if you require('tls') you must do the !crypto skip?

@danbev
Copy link
Contributor Author

danbev commented Jun 15, 2017

@danbev is there a lint rule we could add for this? Something that says that if you require('tls') you must do the !crypto skip?

@gibfahn I'll take a look if this can be added. I think it would also have to cover require('https'), require('crypto') and perhaps others.

We talked about having a CI job for this, one that built using --without-ssl. Is it preferred to have a lint rule instead of that?

@danbev
Copy link
Contributor Author

danbev commented Jun 15, 2017

test/aix failure looks unrelated

console output:

not ok 13 async-hooks/test-fseventwrap
  ---
  duration_ms: 0.185
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED (Signal: 11)

@gibfahn
Copy link
Member

gibfahn commented Jun 15, 2017

We talked about having a CI job for this, one that built using --without-ssl. Is it preferred to have a lint rule instead of that?

I need to do that (it's on my backlog), but a lint rule might be easier (it'd certainly catch things earlier). I'd want to see what other people think about having such a lint rule first though. cc/ @seishun @Trott @not-an-aardvark @mscdex

@gibfahn
Copy link
Member

gibfahn commented Jun 15, 2017

AIX failure is indeed unrelated, see #13577

danbev added a commit to danbev/node that referenced this pull request Jun 17, 2017
Currently, there are a few test-tls-wrap-econnreset test that fail when
Node is configured --without-ssl:
Error: Node.js is not compiled with openssl crypto support

This commit adds crypto checks and skips these tests if no crypto
support unavailable.

PR-URL: nodejs#13691
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev
Copy link
Contributor Author

danbev commented Jun 17, 2017

Landed in 7bdb5ca

@danbev danbev closed this Jun 17, 2017
@danbev danbev deleted the test-tls-wrap-connreset-crypto-checks branch June 17, 2017 17:17
addaleax pushed a commit that referenced this pull request Jun 18, 2017
Currently, there are a few test-tls-wrap-econnreset test that fail when
Node is configured --without-ssl:
Error: Node.js is not compiled with openssl crypto support

This commit adds crypto checks and skips these tests if no crypto
support unavailable.

PR-URL: #13691
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jun 20, 2017
Currently, there are a few test-tls-wrap-econnreset test that fail when
Node is configured --without-ssl:
Error: Node.js is not compiled with openssl crypto support

This commit adds crypto checks and skips these tests if no crypto
support unavailable.

PR-URL: #13691
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Jun 21, 2017
addaleax pushed a commit that referenced this pull request Jun 21, 2017
Currently, there are a few test-tls-wrap-econnreset test that fail when
Node is configured --without-ssl:
Error: Node.js is not compiled with openssl crypto support

This commit adds crypto checks and skips these tests if no crypto
support unavailable.

PR-URL: #13691
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jun 24, 2017
Currently, there are a few test-tls-wrap-econnreset test that fail when
Node is configured --without-ssl:
Error: Node.js is not compiled with openssl crypto support

This commit adds crypto checks and skips these tests if no crypto
support unavailable.

PR-URL: #13691
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 29, 2017
Currently, there are a few test-tls-wrap-econnreset test that fail when
Node is configured --without-ssl:
Error: Node.js is not compiled with openssl crypto support

This commit adds crypto checks and skips these tests if no crypto
support unavailable.

PR-URL: #13691
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
Currently, there are a few test-tls-wrap-econnreset test that fail when
Node is configured --without-ssl:
Error: Node.js is not compiled with openssl crypto support

This commit adds crypto checks and skips these tests if no crypto
support unavailable.

PR-URL: #13691
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
Currently, there are a few test-tls-wrap-econnreset test that fail when
Node is configured --without-ssl:
Error: Node.js is not compiled with openssl crypto support

This commit adds crypto checks and skips these tests if no crypto
support unavailable.

PR-URL: #13691
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants