Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix typos #13741

Closed
wants to merge 2 commits into from
Closed

lib: fix typos #13741

wants to merge 2 commits into from

Conversation

BridgeAR
Copy link
Member

Just some small typos.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jun 17, 2017
mscdex
mscdex reviewed Jun 17, 2017
View reviewed changes
lib/internal/socket_list.js Outdated
@@ -2,7 +2,7 @@

const EventEmitter = require('events');

// This object keep track of the socket there are sended
// This object keeps track of the socket that is send
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/send/sent/ ?

@silverwind
Copy link
Contributor

silverwind commented Jun 17, 2017 •
edited
Loading

I think some of these were fixed in ecf6a46 which just landed, you should rebase.

mscdex
mscdex reviewed Jun 18, 2017
View reviewed changes
lib/internal/socket_list.js Outdated
@@ -2,7 +2,7 @@

const EventEmitter = require('events');

// This object keep track of the socket there are sended
// This object keeps track of the socket that is sent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure, but I think it should be 'sockets' instead of 'socket' and then s/is/are/

Also, the SocketListReceive description below needs to be updated similarly as well.

cjihrig
cjihrig approved these changes Jun 19, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @mscdex's comment is addressed.

@silverwind
Copy link
Contributor

Thanks! Landed in c474f88.

@silverwind silverwind closed this Jun 19, 2017
silverwind pushed a commit that referenced this pull request Jun 19, 2017
@BridgeAR @silverwind
lib: fix typos
c474f88 
PR-URL: #13741
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
refack
refack reviewed Jun 20, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(fondly reminded of inspector Enbale)

@addaleax
Copy link
Member

This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR, if you don’t think it’s worth it let me know and we’ll add the dont-land-on label.

@BridgeAR
Copy link
Member Author

BridgeAR commented Jul 2, 2017

I'll open a backport some time later tonight.

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jul 2, 2017
@BridgeAR
lib: fix typos
e02be07 
PR-URL: nodejs#13741
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jul 2, 2017
Closed
4 tasks
addaleax pushed a commit that referenced this pull request Jul 3, 2017
@BridgeAR @addaleax
lib: fix typos
95ab616 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@BridgeAR @addaleax
lib: fix typos
8a467ae 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@BridgeAR @addaleax
lib: fix typos
4bb1a3a 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
@BridgeAR @MylesBorins
lib: fix typos
d133e33 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
@BridgeAR @MylesBorins
lib: fix typos
600d009 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@BridgeAR @MylesBorins
lib: fix typos
81edf59 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
@BridgeAR BridgeAR deleted the fix-typos branch April 1, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack left review comments

@mscdex mscdex mscdex left review comments

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.