Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console,internal/errors: improve error perf #13743

Closed
wants to merge 2 commits into from
Closed

console,internal/errors: improve error perf #13743

wants to merge 2 commits into from

Commits on Jun 19, 2017

  1. console: use a plain object for the the error stack 

    Using a object instead of an Error is sufficient as the Error
itself won't be used but only the stack trace that would
otherwise be created twice.

This improves the overall .trace() performance.
    @BridgeAR
    BridgeAR committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    f0baeea View commit details
    Browse the repository at this point in the history

  2. internal/errors: prevent stack recalculation 

    Newer v8 versions exclude the constructor from the stack trace
so the recalculation of the trace can be avoided.
    @BridgeAR
    BridgeAR committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    e16faad View commit details
    Browse the repository at this point in the history