test: accommodate AIX by watching file #13766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watching directories has limited support on AIX. This is documented. Watch a file in test/async-hooks/test-fseventwrap.js to accommodate AIX. Refs: nodejs#13577 (comment)
Trott
added
aix
nodejs-github-bot
added
async_hooks
gibfahn
approved these changes
Jun 18, 2017
cjihrig
approved these changes
Jun 18, 2017
hiroppy
approved these changes
Jun 19, 2017
mhdawson
approved these changes
Jun 19, 2017
gireeshpunathil
approved these changes
Jun 19, 2017
jasnell
approved these changes
Jun 19, 2017
jasnell
pushed a commit
that referenced
this pull request
Jun 20, 2017
Watching directories has limited support on AIX. This is documented. Watch a file in test/async-hooks/test-fseventwrap.js to accommodate AIX. PR-URL: #13766 Ref: #13577 (comment) Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 275d0b3 |
addaleax
pushed a commit
that referenced
this pull request
Jun 20, 2017
Watching directories has limited support on AIX. This is documented. Watch a file in test/async-hooks/test-fseventwrap.js to accommodate AIX. PR-URL: #13766 Ref: #13577 (comment) Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
I 'think' there was a failure after this commit landed: Will keep an eye out for future failures. |
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 21, 2017
Watching directories has limited support on AIX. This is documented. Watch a file in test/async-hooks/test-fseventwrap.js to accommodate AIX. PR-URL: #13766 Ref: #13577 (comment) Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
@mhdawson I think that's mostly-expected. @gireeshpunathil laid out three issues with the test, and this only addressed one of them. See #13577 (comment) |
|
ok, I'll keep an eye on it, if we still see regular failures I may look at moving to flaky until we figure out the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watching directories has limited support on AIX. This is documented.
Watch a file in test/async-hooks/test-fseventwrap.js to accommodate AIX.
Refs: #13577 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test fs async_hooks