-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update debugger.md #13777
doc: update debugger.md #13777
Conversation
Yikes! Shouldn't |
@nodejs/diagnostics |
It should probably just be deleted. I forgot to when I removed |
It should be updated to use |
So should we close this PR for now? I think I cannot completely refactor it for |
@vsemozhetbyt Thanks for looking into those docs & sorry that they are somewhat out of date now. I'll try to work on that later this week unless someone else volunteers earlier. Quick explanation about "quit": "kill" kills the program being debugged so you can restart it w/o losing the debug session, e.g. breakpoints you set. It doesn't exit the CLI debugger itself like "quit" used to. I might have found that myself if I wouldn't developed the habit of using Ctrl+D to quit the debugger. :( Generally @targos is right - |
@jkrems Thank you for the feedback. I think I better close this PR for now as the issue needs a more drastic solution. Feel free to reopen if I am wrong. |
Checklist
Affected core subsystem(s)
doc, debugger
Some output seems weird, but that is what we have in the Nod.js 8.1.1.
Considering
DeprecationWarning
in the outputs, isStability: 2 - Stable
still valid?I've duplicated the note about UUID as it is a part of the
debug
output now.quit
command from the old output throws now:In the output of the
help
command there is only this suitable command:kill Kill a running application or disconnect
but its behavior is weird: first, it duplicates header lines, then does nothing:
.exit
seems OK, so I've added it instead.I am not sure if some of these nits are bugs that should be addressed.
test/fixtures/break-in-module/mod.js
seems to be changed recently again (copyright added), so the corresponding example is also updated along with other changes indebug
behavior.Inspector output is also updated.
'Chrome Debugging Protocol' link is replaced according to the current redirection.