[v8.x] deps: update V8 to 5.9.211.37 #13790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
v8 engine
|
V8 diff: v8/v8@5.9.211.35...5.9.211.37 |
bnoordhuis
approved these changes
Jun 19, 2017
|
Also, how come v8.x is ahead of master? These are strange and unsettling times we live in. |
|
I did not really expect my 5.9 PR to be landed on v8.x before #13631. I thought we were waiting for the CITGM checks. Maybe I should have marked it as blocked until then. |
addaleax
approved these changes
Jun 19, 2017
|
I landed #13631 on master today. CI: https://ci.nodejs.org/job/node-test-pull-request/8759/ |
addaleax
pushed a commit
that referenced
this pull request
Jun 20, 2017
PR-URL: #13790 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in e47fd6d @ v8.x-staging, thank you! |
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 21, 2017
PR-URL: #13790 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Jun 24, 2017
PR-URL: #13790 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg
pushed a commit
that referenced
this pull request
Jun 29, 2017
PR-URL: #13790 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
PR-URL: #13790 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
PR-URL: #13790 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
to targos/node
that referenced
this pull request
Jul 21, 2017
PR-URL: nodejs#13790 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Jul 24, 2017
PR-URL: #13790 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nodejs/v8
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
V8