Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add eslint rule for inspector checking #13814

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jun 20, 2017

The motivation for this commit is to pick up early on missing checks for
inspector support (when Node is built --without-inspector).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

The motivation for this commit is to pick up early on missing checks for
inspector support (when Node is built --without-inspector).
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 20, 2017
@danbev
Copy link
Contributor Author

danbev commented Jun 20, 2017

@vsemozhetbyt vsemozhetbyt added the test Issues and PRs related to the tests. label Jun 20, 2017
@cjihrig
Copy link
Contributor

cjihrig commented Jun 20, 2017

It would be nice to combine this with the rule in #13813.

@danbev
Copy link
Contributor Author

danbev commented Jun 20, 2017

It would be nice to combine this with the rule in #13813.

I thought it might make it easier to review and maintain having them as separate rules. But I can merge them together if that is preferred.

@cjihrig
Copy link
Contributor

cjihrig commented Jun 20, 2017

I think they are similar enough that the rule can be parameterized. They're both checking "if module X is required, make sure there is an if statement to skip the test."

@danbev
Copy link
Contributor Author

danbev commented Jun 20, 2017

I think they are similar enough that the rule can be parameterized. They're both checking "if module X is required, make sure there is an if statement to skip the test."

I'll give it a try, closing this for now.

@danbev danbev closed this Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants