readline: fix calling constructor without new #1385
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works:
$ iojs -e 'new (require("readline").Interface)({ input: process.stdin, output: process.stdout })'
This doesn't:
The reason is that
option
object detection here relies on a number of arguments passed to the constructor.But
instanceof
guard here always makes it four arguments.So the issue happens when usual
instanceof
check is combined with logic based onarguments.length
.There are two places in
io.js
core when it matters. Second one is in buffer.js and it's already handled correctly.