Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneccessary Buffer require #13851

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/parallel/test-buffer-nopendingdep-map.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
// Flags: --no-warnings --pending-deprecation
// Flags: --no-warnings --pending-deprecation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this indent intentional?

'use strict';

const common = require('../common');
const Buffer = require('buffer').Buffer;

process.on('warning', common.mustNotCall('A warning should not be emitted'));

Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-buffer-pending-deprecation.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
'use strict';

const common = require('../common');
const Buffer = require('buffer').Buffer;

const bufferWarning = 'The Buffer() and new Buffer() constructors are not ' +
'recommended for use due to security and usability ' +
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-buffer-sharedarraybuffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
// Flags: --harmony-sharedarraybuffer

require('../common');
const assert = require('assert');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this deletion is accidental.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lenakaplan Could you also undo this assert deletion so we can run a new CI on this PR?

const Buffer = require('buffer').Buffer;

const sab = new SharedArrayBuffer(24);
const arr1 = new Uint16Array(sab);
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-buffer-slow.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
const common = require('../common');
const assert = require('assert');
const buffer = require('buffer');
const Buffer = buffer.Buffer;
const SlowBuffer = buffer.SlowBuffer;

const ones = [1, 1, 1, 1];
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-buffer-tojson.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

require('../common');
const assert = require('assert');
const Buffer = require('buffer').Buffer;

{
assert.strictEqual(JSON.stringify(Buffer.alloc(0)),
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-buffer-zero-fill.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

require('../common');
const assert = require('assert');
const Buffer = require('buffer').Buffer;

const buf1 = Buffer(100);
const buf2 = new Buffer(100);
Expand Down