Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v6.x backport) test: make the rest of tests path-independent #13880

Closed
wants to merge 1 commit into from
Closed

(v6.x backport) test: make the rest of tests path-independent #13880

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Backport of #12972

@vsemozhetbyt
test: make the rest of tests path-independent
d3325b6 
Permit spaces in paths to a Node.js executable and test scripts.

PR-URL: #12972
Fixes: #12773
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Jun 22, 2017
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Jun 22, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/8806/

test/osx fail seems unrelated (parallel/test-fs-read-buffer-tostring-fail timeout).

@vsemozhetbyt vsemozhetbyt mentioned this pull request Jun 22, 2017
Closed
2 tasks
@MylesBorins
Copy link
Contributor

landed in 43fcb8f

@vsemozhetbyt vsemozhetbyt deleted the backport-12972-to-v6.x branch July 10, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsemozhetbyt @MylesBorins @nodejs-github-bot