-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add note about python installer #13881
Conversation
@@ -163,7 +163,8 @@ $ [sudo] make install | |||
|
|||
Prerequisites: | |||
|
|||
* [Python 2.6 or 2.7](https://www.python.org/downloads/) | |||
* [Python 2.6 or 2.7](https://www.python.org/downloads/) | |||
*Note*: It is recommanded to include the "Add python.exe to path" option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommanded -> recommended ?
Is it a too soft word? Does not build fail without this option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So maybe we should add a note about the alternative ("add it to %Path%
manually") if the #13882 has any chance to not cover all the cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a note about the alternative ("add it to %Path% manually")
🤔 I don't like "spoon feeding" devs, so I need to think about this.
P.S. The installer will register the installation so #13882 should cover that. (To avoid that I have a special tool that extracts msi
files so I can xcopy the extracted files to where I like, and then I do what's necessary for my system to work.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with #13882 landing rather than this note.
I like spoon feeding devs when it comes to tooling (and not code) - I don't want the fact building is hard or unclear to prevent contributors from joining.
Superseded by #13900 |
Ref: nodejs/CTC#147 (comment)
Checklist
Affected core subsystem(s)
doc,meta