Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add note about python installer #13881

Closed
wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Jun 22, 2017

Ref: nodejs/CTC#147 (comment)

Checklist
Affected core subsystem(s)

doc,meta

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jun 22, 2017
@refack refack added the meta Issues and PRs related to the general management of the project. label Jun 22, 2017
@@ -163,7 +163,8 @@ $ [sudo] make install

Prerequisites:

* [Python 2.6 or 2.7](https://www.python.org/downloads/)
* [Python 2.6 or 2.7](https://www.python.org/downloads/)
*Note*: It is recommanded to include the "Add python.exe to path" option
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommanded -> recommended ?

Is it a too soft word? Does not build fail without this option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I don't like installers, so I add it to %Path% manually.
Also there's PEP-0514 (#13882) which I also do manually 😊

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So maybe we should add a note about the alternative ("add it to %Path% manually") if the #13882 has any chance to not cover all the cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a note about the alternative ("add it to %Path% manually")

🤔 I don't like "spoon feeding" devs, so I need to think about this.
P.S. The installer will register the installation so #13882 should cover that. (To avoid that I have a special tool that extracts msi files so I can xcopy the extracted files to where I like, and then I do what's necessary for my system to work.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with #13882 landing rather than this note.

I like spoon feeding devs when it comes to tooling (and not code) - I don't want the fact building is hard or unclear to prevent contributors from joining.

@mscdex mscdex removed the meta Issues and PRs related to the general management of the project. label Jun 22, 2017
@refack refack changed the title doc,meta: add note about python installer doc: add note about python installer Jun 22, 2017
@refack
Copy link
Contributor Author

refack commented Jun 28, 2017

Superseded by #13900

@refack refack closed this Jun 28, 2017
@refack refack deleted the building-with-python branch June 28, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants