doc: add documentation on ICU #13916
Conversation
|
If it remains in the |
doc/api/intl.md
Outdated
| in native C/C++ code. However, some of them require a very large ICU data file | ||
| in order to support all locales of the world. Since most Node.js users will | ||
| make use of only a small section in the full ICU data set, we provide several | ||
| options for customizing ICU support in a Node.js build. |
There was a problem hiding this comment.
Please avoid use of informal pronouns like we in the docs... Also, this last sentence is a bit off for me... Perhaps:
Because it is expected that most Node.js users will make use of only a small portion
of ICU functionality, only a subset of the full ICU data set is provided by Node.js by
default. Several options are provided for customizing and expanding the ICU data set
either when building or running Node.js.
doc/api/intl.md
Outdated
|
|
||
| Node.js can link against an ICU build already installed on the system. In fact, | ||
| most Linux distributions already come with ICU installed, and this option would | ||
| make it possible to reuse the same set of data used by other components in your |
There was a problem hiding this comment.
Please avoid using informal pronouns like your in the docs.
doc/api/intl.md
Outdated
|
|
||
| #### Providing ICU data at runtime | ||
|
|
||
| If you use the `small-icu` option, you can still provide additional locale data |
There was a problem hiding this comment.
As above, please avoid using informal pronouns like you
|
@jasnell Comments are addressed. What are your thoughts on where this document should end up? |
|
I'll merge this tomorrow if there are no more comments. |
|
Linter (you may need to rebase after the 15599cb): |
Looks like this is staying in node/node.
|
Not too big of a fan of the linter change, but changed. Linter CI: https://ci.nodejs.org/job/node-test-linter/10274/ |
|
@TimothyGu It seems it is due to 7477f9b, but I wanted to be on safe side with updated tools) |
|
Landed in 6809429 |
PR-URL: #13916 Refs: #13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
PR-URL: #13916 Refs: #13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
PR-URL: #13916 Refs: #13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
PR-URL: #13916 Refs: #13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
|
Is this applicable to v6.x? It is easy enough to land this but I want to ensure that it makes sense for the version of ICU that is embedded 6.x: 58.2 |
|
@MylesBorins Yep, most of the content is applicable to 6.x as well, but some things need to be changed (e.g. mentions of the WHATWG URL API as it doesn't exist in 6.x). |
PR-URL: nodejs#13916 Refs: nodejs#13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
PR-URL: #13916 Refs: #13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Adapted from the wiki article "Intl" by @srl295. Open to suggestions w.r.t. where this page belongs best, either here or on nodejs.org, but somewhere more permanent than a wiki.
Refs: #13644 (comment)
Checklist
Affected core subsystem(s)
doc