-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: OutgoingMessage change writable after end #14024
Closed
Kasher
wants to merge
4
commits into
nodejs:master
from
Kasher:http_outgoing_mark_as_not_writable_upon_close
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const http = require('http'); | ||
|
||
// Verify that after calling end() on an `OutgoingMessage` (or a type that | ||
// inherits from `OutgoingMessage`), its `writable` property is set to false. | ||
|
||
const server = http.createServer(common.mustCall(function(req, res) { | ||
assert.strictEqual(res.writable, true); | ||
assert.strictEqual(res.finished, false); | ||
res.end(); | ||
assert.strictEqual(res.writable, false); | ||
assert.strictEqual(res.finished, true); | ||
|
||
server.close(); | ||
})); | ||
|
||
server.listen(0); | ||
|
||
server.on('listening', common.mustCall(function() { | ||
const clientRequest = http.request({ | ||
port: server.address().port, | ||
method: 'GET', | ||
path: '/' | ||
}); | ||
|
||
assert.strictEqual(clientRequest.writable, true); | ||
clientRequest.end(); | ||
assert.strictEqual(clientRequest.writable, false); | ||
})); |
39 changes: 39 additions & 0 deletions
39
test/parallel/test-pipe-outgoing-message-data-emitted-after-ended.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const http = require('http'); | ||
const util = require('util'); | ||
const stream = require('stream'); | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a little explanation here as well? |
||
// Verify that when piping a stream to an `OutgoingMessage` (or a type that | ||
// inherits from `OutgoingMessage`), if data is emitted after the | ||
// `OutgoingMessage` was closed - no `write after end` error is raised (this | ||
// should be the case when piping - when writing data directly to the | ||
// `OutgoingMessage` this error should be raised). | ||
|
||
function MyStream() { | ||
stream.call(this); | ||
} | ||
util.inherits(MyStream, stream); | ||
|
||
const server = http.createServer(common.mustCall(function(req, res) { | ||
const myStream = new MyStream(); | ||
myStream.pipe(res); | ||
|
||
process.nextTick(common.mustCall(() => { | ||
res.end(); | ||
myStream.emit('data', 'some data'); | ||
|
||
// If we got here - 'write after end' wasn't raised and the test passed. | ||
process.nextTick(common.mustCall(() => server.close())); | ||
})); | ||
})); | ||
|
||
server.listen(0); | ||
|
||
server.on('listening', common.mustCall(function() { | ||
http.request({ | ||
port: server.address().port, | ||
method: 'GET', | ||
path: '/' | ||
}).end(); | ||
})); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a little comment explaining what this test is about here?