aix: fix un-initialized pointer field in fs handle #14071
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In AIX, fs watch close call was corrupting memory in the compiler. The handle->dir_filename field can be un-initialized, if the watch is initiated but not event got fired. But the uv_fs_event_stop was freeing this pointer as if it was malloc'ed, leading to the crash. Properly initialize handle-dir_filename to avoid a garbage pointer. Fixes: nodejs#13577
nodejs-github-bot
added
the
libuv
|
@gireeshpunathil you should open a libuv PR as well |
refack
added
aix
|
@refack -sure. |
|
This should go into libuv first and then it will automatically end up in node on the next upgrade (which is probably later this week or next week.) I'll close this, we don't normally float libuv patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AIX, fs watch close call was corrupting memory in the compiler.
The handle->dir_filename field can be un-initialized, if the watch
is initiated but not event got fired. But the uv_fs_event_stop was
freeing this pointer as if it was malloc'ed, leading to the crash.
Properly initialize handle-dir_filename to avoid a garbage pointer.
Fixes: #13577
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)