Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ignore connection errors for hostname check #14073

Merged
merged 1 commit into from
Jul 9, 2017

Conversation

refack
Copy link
Contributor

@refack refack commented Jul 4, 2017

Follow up to #14065
Be more explicit about why we don't care about errors

/cc @Trott @nodejs/testing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 4, 2017
@refack
Copy link
Contributor Author

refack commented Jul 4, 2017

I've become so dependent on my IDE, every time I try the GitHub GUI, major failage:
image
New CI: https://ci.nodejs.org/job/node-test-commit/10948/

@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Jul 4, 2017
@Trott
Copy link
Member

Trott commented Jul 5, 2017

I'm totally neutral on this change. No objection. Feel free to land if Ci is green and no one objects after the 48 hours are up. I'm only commenting because I got @-mentioned. :-D

PR-URL: nodejs#14073
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@refack refack merged commit 4d7946a into nodejs:master Jul 9, 2017
@refack refack deleted the i-dont-care-i-love-it branch July 9, 2017 18:05
addaleax pushed a commit that referenced this pull request Jul 11, 2017
PR-URL: #14073
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax mentioned this pull request Jul 11, 2017
addaleax pushed a commit that referenced this pull request Jul 18, 2017
PR-URL: #14073
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
PR-URL: #14073
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants