path: fix normalize on directories with two dots #14107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's probably not the best way to fix the issue. /cc @mscdex |
refack
reviewed
Jul 6, 2017
test/parallel/test-path.js
Outdated
| @@ -406,6 +406,7 @@ assert.strictEqual(path.win32.normalize('a//b//.'), 'a\\b'); | |||
| assert.strictEqual(path.win32.normalize('//server/share/dir/file.ext'), | |||
| '\\\\server\\share\\dir\\file.ext'); | |||
| assert.strictEqual(path.win32.normalize('/a/b/c/../../../x/y/z'), '\\x\\y\\z'); | |||
| assert.strictEqual(path.win32.normalize('bar\\foo..\\..\\'), 'bar\\'); | |||
There was a problem hiding this comment.
Could you add:
assert.strictEqual(path.win32.normalize('bar\\foo..\\..\\'), 'bar\\');
assert.strictEqual(path.win32.normalize('bar\\foo..\\..\\baz'), 'bar\\baz');
assert.strictEqual(path.win32.normalize('bar\\foo..\\'), 'bar\\foo..');Or alternatively find the coverage
targos
force-pushed
the
fix-path-normalize
branch
2 times, most recently
from
eb9ff15
to
1250227
Compare
refack
approved these changes
Jul 7, 2017
Good luck. |
|
This needs a rebase |
targos
force-pushed
the
fix-path-normalize
branch
from
1250227
to
092094d
Compare
|
Looks like I forgot about this PR... Done. |
|
CI failed on arm, trying again https://ci.nodejs.org/job/node-test-commit-arm/11784/ |
targos
added a commit
to targos/node
that referenced
this pull request
Aug 30, 2017
PR-URL: nodejs#14107 Fixes: nodejs#14105 Reviewed-By: Refael Ackermann <refack@gmail.com>
|
Landed in b98e8d9 |
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
PR-URL: nodejs/node#14107 Fixes: nodejs/node#14105 Reviewed-By: Refael Ackermann <refack@gmail.com>
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
PR-URL: nodejs/node#14107 Fixes: nodejs/node#14105 Reviewed-By: Refael Ackermann <refack@gmail.com>
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Aug 31, 2017
PR-URL: nodejs#14107 Fixes: nodejs#14105 Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
|
I've backported to v6.x Please let me know if it should be backed out |
Merged
|
I've landed this back on v6.x along with 19d2d6611c which fixed the security vulnerability. Please let me know if you think they should be backed out /cc @nodejs/security @nodejs/tsc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14105
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
path