-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix error in eslintrc comment #14108
Conversation
46d7cb8 introduced an error in a comment in `.eslintrc.yaml`. The second option needs to be an integer specifying the number of spaces per level of indentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was sure I excluded it. Probably leaked in during a last minute rebase.
Given rapid approvals and trivial nature of change, I'm going to land this now. |
Landed in 3d8a9e2 |
46d7cb8 introduced an error in a comment in `.eslintrc.yaml`. The second option needs to be an integer specifying the number of spaces per level of indentation. PR-URL: #14108 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
46d7cb8 introduced an error in a comment in `.eslintrc.yaml`. The second option needs to be an integer specifying the number of spaces per level of indentation. PR-URL: #14108 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
46d7cb8 introduced an error in a comment in `.eslintrc.yaml`. The second option needs to be an integer specifying the number of spaces per level of indentation. PR-URL: #14108 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
46d7cb8 introduced an error in a comment in `.eslintrc.yaml`. The second option needs to be an integer specifying the number of spaces per level of indentation. PR-URL: #14108 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Should this be backported to |
This PR depends on a change that is being backported in #14841. |
46d7cb8 introduced an error in a
comment in
.eslintrc.yaml
. The second option needs to be an integerspecifying the number of spaces per level of indentation.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
tools