Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix mistake in http.md #14126

Closed
wants to merge 2 commits into from
Closed

doc: fix mistake in http.md #14126

wants to merge 2 commits into from

Commits on Jul 7, 2017

  1. doc: fix mistake in http.md 

    If the first parameter of `request.end` `data` is specified, it should
be equivalent to calling `request.write(data, encoding)` (not
`response.write(data, encoding)`) followed by `request.end(callback)`.

This mistake was introduced in commit
14b3aab:

    date: 28 November 2015 at 7:30:32 AM GMT+8
    author: jpersson <jonathan.persson@creuna.se>
    committer: James M Snell <jasnell@gmail.com>
    summary: doc: add links and backticks around names
    @galeo
    galeo committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    57aa9fc View commit details
    Browse the repository at this point in the history

  2. doc: add reference for request.write in http.md 

    This should finish up the previous commit.

Refs: #14126
    @galeo
    galeo committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    889becc View commit details
    Browse the repository at this point in the history