Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: include cached modules in module.children #14132

Merged
merged 1 commit into from
Jul 24, 2017

Commits on Jul 24, 2017

  1. lib: include cached modules in module.children

    `module.children` is supposed to be the list of modules included by this
    module but lib/module.js failed to update the list when the included
    module was retrieved from `Module._cache`.
    
    Fixes: nodejs#7131
    PR-URL: nodejs#14132
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    bnoordhuis committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    c83d9bb View commit details
    Browse the repository at this point in the history