Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-https-set-timeout-server #14134

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-https-set-timeout-server #14134

wants to merge 1 commit into from

Commits on Jul 8, 2017

  1. test: fix flaky test-https-set-timeout-server 

    Because of a race condition, connection listener may not be invoked if
test is run under load. Remove `common.mustCall()` wrapper from the
listener. Move the test to `parallel` because it now works under load.
Make similar change to http test to keep them in synch even though it is
much harder to trigger the race in http.

Fixes: nodejs#14133
    @Trott
    Trott committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    25d6100 View commit details
    Browse the repository at this point in the history