[v8.x backport] doc: removed redundant mentions to error codes #14175
Conversation
PR-URL: nodejs#13627 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs-github-bot
added
doc
doc/api/errors.md
Outdated
|
|
||
| <a id="ERR_FALSY_VALUE_REJECTION"></a> | ||
| ### ERR_FALSY_VALUE_REJECTION | ||
|
|
||
| Used by the `util.callbackify()` API when a callbackified `Promise` is rejected | ||
| with a falsy value (e.g. `null`). | ||
| The `ERR_FALSY_VALUE_REJECTION` error code is used by the `util.callbackify()` |
There was a problem hiding this comment.
Isn't this one wrong way around?
There was a problem hiding this comment.
Whoops, was too hasty. Thanks for the catch.
| value]` tuple – that is, if an element is not iterable, or does not consist of | ||
| exactly two elements. | ||
| Used when an element in the `iterable` provided to the [WHATWG][WHATWG URL | ||
| API] [`URLSearchParams`constructor][`new URLSearchParams(iterable)`] does not |
There was a problem hiding this comment.
There should be a space between "URLSearchParams" and "constructor".
There was a problem hiding this comment.
Should, but by the magic of GFM it works:
There was a problem hiding this comment.
@refack what you are seeing is just GitHub's CSS. This won't be the case on Node.js' website. Even in GH, copying the text via the clipboard will not contain a space, nor will the browser insert a line break even if one is needed there.
There was a problem hiding this comment.
This issue is in master. I guess it should be addressed with a PR there that then gets backported to 8.x.
Backport of #13627
PR-URL: #13627
Reviewed-By: Daniel Bevenius daniel.bevenius@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Timothy Gu timothygu99@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc