Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: codesign tarball binary on macOS #14179

Merged
merged 2 commits into from
Jul 19, 2017
Merged

build: codesign tarball binary on macOS #14179

merged 2 commits into from
Jul 19, 2017

Commits on Jul 19, 2017

  1. build,tools: do not force codesign prefix 

    Allow passing the prefix in via the PKGDIR env var. This will allow us
to use this same script to codesign the binary tarball.

PR-URL: nodejs#14179
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @evanlucas
    evanlucas committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    2309f3a View commit details
    Browse the repository at this point in the history

  2. build: codesign tarball binary on macOS 

    Previously, we were signing the binary that was released in the .pkg,
but not the binary released in the tarball.

PR-URL: nodejs#14179
Fixes: nodejs#11936
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @evanlucas
    evanlucas committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    e36166b View commit details
    Browse the repository at this point in the history