Skip to content

n-api: directly create Local from Persistent #14211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

n-api: directly create Local from Persistent #14211

wants to merge 1 commit into from

Conversation

@kfarnung
Copy link
Contributor

@kfarnung kfarnung commented Jul 13, 2017 •
edited
Loading

The v8::PersistentBase<T>.Get method didn't exist in node 4 and it's
just a helper which creates a new v8::Local from the given object.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

n-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Jul 13, 2017
@kfarnung
Copy link
Contributor Author

kfarnung commented Jul 13, 2017

/cc @mhdawson @gabrielschulhof @jasongin

@kfarnung kfarnung mentioned this pull request Jul 13, 2017
Closed
mhdawson
mhdawson approved these changes Jul 13, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfarnung
Copy link
Contributor Author

kfarnung commented Jul 13, 2017

Rebased and new CI: https://ci.nodejs.org/job/node-test-pull-request/9115/

@kfarnung
Copy link
Contributor Author

kfarnung commented Jul 17, 2017 •
edited
Loading

Rebased again with new CI: https://ci.nodejs.org/job/node-test-pull-request/9233/

@kfarnung
Copy link
Contributor Author

kfarnung commented Jul 21, 2017

This should be ready to land, from what I can see the CI shows only known issues.

/cc @mhdawson @jasongin

@kfarnung
Copy link
Contributor Author

kfarnung commented Jul 25, 2017

New CI run: https://ci.nodejs.org/job/node-test-pull-request/9348/

@kfarnung
n-api: directly create Local from Persistent
787f09b 
The `v8::PersistentBase<T>.Get` method didn't exist in node 4 and it's
just a helper which creates a new `v8::Local` from the given object.
@kfarnung
Copy link
Contributor Author

kfarnung commented Jul 26, 2017

Rebased and started a new CI: https://ci.nodejs.org/job/node-test-pull-request/9359/

@addaleax
Copy link
Member

addaleax commented Jul 26, 2017

Landed in e59987c, thanks!

@addaleax addaleax closed this Jul 26, 2017
addaleax pushed a commit that referenced this pull request Jul 26, 2017
@kfarnung @addaleax
n-api: directly create Local from Persistent
e59987c 
The `v8::PersistentBase<T>.Get` method didn't exist in node 4 and it's
just a helper which creates a new `v8::Local` from the given object.

PR-URL: #14211
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
@kfarnung
Copy link
Contributor Author

kfarnung commented Jul 26, 2017

Thanks @addaleax!

@kfarnung kfarnung deleted the objtemplate branch July 26, 2017 18:27
addaleax pushed a commit that referenced this pull request Jul 27, 2017
@kfarnung @addaleax
n-api: directly create Local from Persistent
6078dea 
The `v8::PersistentBase<T>.Get` method didn't exist in node 4 and it's
just a helper which creates a new `v8::Local` from the given object.

PR-URL: #14211
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
@addaleax addaleax mentioned this pull request Aug 2, 2017
Merged
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@kfarnung
n-api: directly create Local from Persistent
39ce757 
The `v8::PersistentBase<T>.Get` method didn't exist in node 4 and it's
just a helper which creates a new `v8::Local` from the given object.

PR-URL: nodejs#14211
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@kfarnung @MylesBorins
n-api: directly create Local from Persistent
1acab66 
The `v8::PersistentBase<T>.Get` method didn't exist in node 4 and it's
just a helper which creates a new `v8::Local` from the given object.

Backport-PR-URL: #19447
PR-URL: #14211
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

+2 more reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@jasongin jasongin jasongin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@kfarnung @addaleax @jasnell @gabrielschulhof @TimothyGu @cjihrig @mhdawson @jasongin @MylesBorins @nodejs-github-bot