Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x backport] build: allow enabling the --trace-maps flag in V8 #14344

Closed

Conversation

evanlucas
Copy link
Contributor

Backport of #14018 to v8.x

This can be useful for tracing map creation.

PR-URL: #14018
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Refael Ackermann refack@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

This can be useful for tracing map creation.

PR-URL: nodejs#14018
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8.x labels Jul 18, 2017
@addaleax
Copy link
Member

I don’t think running CI for this makes sense, but make test passes locally with the flag included. 👍

Thanks, landed in v8.x-staging!

@addaleax addaleax closed this Jul 18, 2017
addaleax pushed a commit that referenced this pull request Jul 18, 2017
This can be useful for tracing map creation.

Backport-PR-URL: #14344
Backport-Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Backport-Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #14018
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
This can be useful for tracing map creation.

Backport-PR-URL: #14344
Backport-Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Backport-Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #14018
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants