Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix some links #14400

Closed
wants to merge 2 commits into from
Closed

doc: fix some links #14400

wants to merge 2 commits into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jul 20, 2017

Checklist
Affected core subsystem(s)

doc

I am not sure about [][] type links in the DNS doc. Do they mean two-dimensional array, as stated in the dns.resolveTxt() description? If so, let me know to revert (and they should be fixed in doc tools as now they are not rendered as links).

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 20, 2017
@mscdex mscdex added dns Issues and PRs related to the dns subsystem. node-api Issues and PRs related to the Node-API. v8 engine Issues and PRs related to the V8 dependency. labels Jul 20, 2017
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Jul 21, 2017

I've fixed another one in doc/guides/writing-tests.md.

(https://github.com/nodejs/lts). [node.green](http://node.green/) lists
available features in each release.
features that can be used directly without a flag in
[all maintained branches](https://github.com/nodejs/lts).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move these links to the bottom as we usually do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 5 links in the doc without references. Should I move them all to the bottom?

Copy link
Member

@tniessen tniessen Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely sure, but considering that there are three links in the footer, I would prefer consistency. In most cases that makes sense, but barely for [here](https://github.com/nodejs/testing/issues/27). I am fine if you leave it as it is, just wanted to suggest that, didn't know there were so many other "inline" links. So feel free to change it or leave it, I really don't know what we should go for.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done for all except [here] ad hoc link.

@vsemozhetbyt
Copy link
Contributor Author

Landed in 4d1e086

@vsemozhetbyt vsemozhetbyt deleted the doc-links branch July 23, 2017 19:12
vsemozhetbyt added a commit that referenced this pull request Jul 23, 2017
PR-URL: #14400
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 24, 2017
PR-URL: #14400
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Jul 24, 2017
@addaleax addaleax mentioned this pull request Aug 2, 2017
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
PR-URL: nodejs#14400
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
Backport-PR-URL: #19447
PR-URL: #14400
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants