doc: fix some links #14400
doc: fix some links #14400
Conversation
mscdex
added
dns
|
I've fixed another one in |
doc/guides/writing-tests.md
Outdated
| (https://github.com/nodejs/lts). [node.green](http://node.green/) lists | ||
| available features in each release. | ||
| features that can be used directly without a flag in | ||
| [all maintained branches](https://github.com/nodejs/lts). |
There was a problem hiding this comment.
Maybe move these links to the bottom as we usually do?
There was a problem hiding this comment.
There are 5 links in the doc without references. Should I move them all to the bottom?
There was a problem hiding this comment.
I am not entirely sure, but considering that there are three links in the footer, I would prefer consistency. In most cases that makes sense, but barely for [here](https://github.com/nodejs/testing/issues/27). I am fine if you leave it as it is, just wanted to suggest that, didn't know there were so many other "inline" links. So feel free to change it or leave it, I really don't know what we should go for.
There was a problem hiding this comment.
Done for all except [here] ad hoc link.
|
Landed in 4d1e086 |
PR-URL: #14400 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #14400 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#14400 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
Affected core subsystem(s)
doc
I am not sure about
[][]type links in the DNS doc. Do they mean two-dimensional array, as stated in thedns.resolveTxt()description? If so, let me know to revert (and they should be fixed in doc tools as now they are not rendered as links).