Skip to content

[v8.x backport] assert: fix incorrect use of ERR_INVALID_ARG_TYPE #14471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v8.x backport] assert: fix incorrect use of ERR_INVALID_ARG_TYPE #14471

wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jul 25, 2017

Partial backport of #14011 to v8.x.

@tniessen
assert: fix incorrect use of ERR_INVALID_ARG_TYPE
24374d8 
PR-URL: nodejs#14011
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@tniessen tniessen added assert Issues and PRs related to the assert subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. v8.x labels Jul 25, 2017
@tniessen tniessen requested a review from addaleax July 25, 2017 09:22
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. v8.x labels Jul 25, 2017
@tniessen
Copy link
Member Author

tniessen commented Jul 25, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9341/

@addaleax
Copy link
Member

addaleax commented Jul 27, 2017

Sorry for the misunderstanding – I backported this as part of #14459 … doesn’t matter anyway, the commits ended up being identical 😄 But still, thank you!

@addaleax addaleax closed this Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax Awaiting requested review from addaleax

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tniessen @addaleax @nodejs-github-bot