test: set module loading error for aix #14511
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gireeshpunathil
approved these changes
Jul 27, 2017
Member
gireeshpunathil
left a comment
gireeshpunathil
left a comment
There was a problem hiding this comment.
Thanks @prakaashkpk for contributing!
tniessen
approved these changes
Jul 27, 2017
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
Code looks good, even though I cannot confirm the correctness for AIX.
lpinca
approved these changes
Jul 27, 2017
cjihrig
approved these changes
Jul 27, 2017
Member
jasnell
approved these changes
Jul 31, 2017
Member
|
previous CI was either hung or abandoned. Issued a fresh one. |
tniessen
reviewed
Aug 2, 2017
Member
There was a problem hiding this comment.
This line exceeds 80 characters, please format the code according to our style guidelines.
Contributor
Author
There was a problem hiding this comment.
I have made the changes accordingly. Please review.
gibfahn
approved these changes
Aug 5, 2017
Member
|
cc/ @nodejs/platform-aix |
Member
In test/parallel/test-module-loading-error.js, an attempt is made to load a text file as a native executable. This gives error messages in a platform specific manner. AIX was not included in the list of platforms. This fix introduces the AIX error messages.
Member
tniessen
pushed a commit
that referenced
this pull request
Aug 10, 2017
In test/parallel/test-module-loading-error.js, an attempt is made to load a text file as a native executable. This results in an error message in a platform specific manner. AIX was not included in the list of platforms. This fix introduces the AIX error messages. PR-URL: #14511 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Member
|
Landed in 8172c8a, thank you for your contribution! 🎉 The trailing whitespace caused the CI linter failure. In the future, you might want to use an editor with |
addaleax
pushed a commit
that referenced
this pull request
Aug 10, 2017
In test/parallel/test-module-loading-error.js, an attempt is made to load a text file as a native executable. This results in an error message in a platform specific manner. AIX was not included in the list of platforms. This fix introduces the AIX error messages. PR-URL: #14511 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
In test/parallel/test-module-loading-error.js, an attempt is made to load a text file as a native executable. This results in an error message in a platform specific manner. AIX was not included in the list of platforms. This fix introduces the AIX error messages. PR-URL: #14511 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In test/parallel/test-module-loading-error.js, an attempt is made to
load a text file as a native executable. This gives error messages in a
platform specific manner.
AIX was not included in the list of platforms. This fix introduces
the AIX error messages.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)