lint: wrap lines which include RegEx exceeding 80 chars #14607

thelostone-mc · 2017-08-03T15:09:37Z

Format commit wrapping lines containing RegEx and exceeding 80
chars.

Fixes: #14586

Files Changed:

test/addons-napi/test_properties/test.js
test/parallel/test-process-versions.js
test/parallel/test-repl.js
test/parallel/test-v8-serdes.js
test/parallel/test-whatwg-url-properties.js
test/parallel/test-zlib-not-string-or-buffer.js

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

test

vsemozhetbyt · 2017-08-03T15:20:24Z

test/parallel/test-repl.js

@@ -142,7 +142,7 @@ function error_test() {
      expect: prompt_unix },
    // But passing the same string to eval() should throw
    { client: client_unix, send: 'eval("function test_func() {")',
-      expect: /\bSyntaxError: Unexpected end of input/ },
+      expect: /^\bSyntaxError: Unexpected end of input/ },


There are some RegExps with the same pattern which are left unchanged (lines 193, 198, 203 etc).

It seems the \b symbol after the ^ is unneeded.

@vsemozhetbyt

Well I tried that. On introducing a ^ in L193 which uses strict mode, I get the Octal literals are not allowed in strict mode error as below: (Same case as in other lines you had mentioned )

Unix data: "(function() { \"use strict\"; return 0755; })()\n ^^^^\n\nSyntaxError: Octal literals are not allowed in strict mode.\n\nnode via Unix socket> node via Unix socket> ", expecting /^SyntaxError: Octal literals are not allowed in strict mode/ assert.js:42

Yeah makes sense. Will do that! Can I go ahead and remove the\b even where I can't introduce a ^ cause of strict mode ?

Oh, sorry, I did not think this broke matching.

I think that removing the \b is safe only if we place ^ before)

Ack and taken care of ^_^

refack

💯 on the wrapping!

thefourtheye · 2017-08-03T15:57:06Z

test/parallel/test-v8-serdes.js

-    () => { v8.Deserializer(); },
-    /^TypeError: Class constructor Deserializer cannot be invoked without 'new'$/
-  );
+  assert.throws(() => {


Nit: Now the whole thing would fit in a single line.

@thefourtheye True! But doesn't it look cleaner this way ?

I'm with @thefourtheye, also could drop the () => { } to get:

assert.throws(v8.Serializer, serializerTypeError);

Now that's clean ✨

Well two against one !! Ack and taken care

Trott · 2017-08-03T20:25:40Z

test/parallel/test-repl.js

    // strict mode syntax errors should be caught (GH-5178)
    { client: client_unix,
      send: '(function() { "use strict"; return 0755; })()',
      expect: /\bSyntaxError: Octal literals are not allowed in strict mode/ },
    {
      client: client_unix,
      send: '(function(a, a, b) { "use strict"; return a + b + c; })()',
-      expect: /\bSyntaxError: Duplicate parameter name not allowed in this context/
+      expect:
+        /\bSyntaxError: Duplicate parameter name not allowed in this context/


Nit \b -> ^?

(And below two instances too?)

It seems this somehow breaks matching: #14607 (comment)

Some error messages quote erroneous code before the error message itself, so for these messages, we can't use ^ anchor (or we should add the /m flag beside).

OK, then \b it is!

Trott

LGTM if CI is green.

vsemozhetbyt · 2017-08-03T20:34:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/9471/

vsemozhetbyt · 2017-08-03T21:31:32Z

One aix fail in CI seems unrelated (parallel/test-async-wrap-getasyncid is crashed).

Trott · 2017-08-03T23:05:41Z

One aix fail in CI seems unrelated (parallel/test-async-wrap-getasyncid is crashed).

Yes, that's a known-flaky on that platform: #14599

@refack and possibly others are investigating.

CI is effectively green for this. 🎉

Format commit wrapping lines containing RegEx and exceeding 80 chars. Fixes: nodejs#14586

vsemozhetbyt · 2017-08-04T08:24:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/9479/

vsemozhetbyt · 2017-08-04T15:49:03Z

CI failures seem unrelated.

Format commit wrapping lines containing RegEx and exceeding 80 chars. PR-URL: nodejs#14607 Fixes: nodejs#14586 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

refack · 2017-08-07T23:22:06Z

Landed in ad664ea
Turned out nice if I may say so myself.

Format commit wrapping lines containing RegEx and exceeding 80 chars. PR-URL: #14607 Fixes: #14586 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

MylesBorins · 2017-09-19T17:24:41Z

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Aug 3, 2017

vsemozhetbyt reviewed Aug 3, 2017

View reviewed changes

refack approved these changes Aug 3, 2017

View reviewed changes

thefourtheye reviewed Aug 3, 2017

View reviewed changes

thelostone-mc force-pushed the shitzu_develop branch from 5279834 to 91b76ad Compare August 3, 2017 19:46

Trott reviewed Aug 3, 2017

View reviewed changes

Trott approved these changes Aug 3, 2017

View reviewed changes

vsemozhetbyt approved these changes Aug 3, 2017

View reviewed changes

thefourtheye approved these changes Aug 3, 2017

View reviewed changes

refack self-assigned this Aug 3, 2017

lint: wrap lines which include RegEx exceeding 80 chars

59d037f

Format commit wrapping lines containing RegEx and exceeding 80 chars. Fixes: nodejs#14586

thelostone-mc force-pushed the shitzu_develop branch from 91b76ad to 59d037f Compare August 4, 2017 06:03

refack mentioned this pull request Aug 6, 2017

CR - max-len: {ignoreRegExpLiterals: true} is too permissive eslint/eslint#9059

Closed

refack closed this Aug 7, 2017

addaleax mentioned this pull request Aug 13, 2017

v8.4.0 proposal #14811

Merged

MylesBorins added the dont-land-on-v6.x label Sep 19, 2017

refack removed their assignment Oct 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lint: wrap lines which include RegEx exceeding 80 chars #14607

lint: wrap lines which include RegEx exceeding 80 chars #14607

thelostone-mc commented Aug 3, 2017 •

edited by refack

Loading

vsemozhetbyt Aug 3, 2017

thelostone-mc Aug 3, 2017

vsemozhetbyt Aug 3, 2017

thelostone-mc Aug 3, 2017

refack left a comment

thefourtheye Aug 3, 2017

thelostone-mc Aug 3, 2017

refack Aug 3, 2017

thelostone-mc Aug 4, 2017

Trott Aug 3, 2017

Trott Aug 3, 2017

vsemozhetbyt Aug 3, 2017

vsemozhetbyt Aug 3, 2017

Trott Aug 6, 2017

Trott left a comment

vsemozhetbyt commented Aug 3, 2017

vsemozhetbyt commented Aug 3, 2017 •

edited

Loading

Trott commented Aug 3, 2017

vsemozhetbyt commented Aug 4, 2017 •

edited

Loading

vsemozhetbyt commented Aug 4, 2017

refack commented Aug 7, 2017

MylesBorins commented Sep 19, 2017

lint: wrap lines which include RegEx exceeding 80 chars #14607

lint: wrap lines which include RegEx exceeding 80 chars #14607

Conversation

thelostone-mc commented Aug 3, 2017 • edited by refack Loading

Checklist

Affected core subsystem(s)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

refack left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Trott left a comment

Choose a reason for hiding this comment

vsemozhetbyt commented Aug 3, 2017

vsemozhetbyt commented Aug 3, 2017 • edited Loading

Trott commented Aug 3, 2017

vsemozhetbyt commented Aug 4, 2017 • edited Loading

vsemozhetbyt commented Aug 4, 2017

refack commented Aug 7, 2017

MylesBorins commented Sep 19, 2017

thelostone-mc commented Aug 3, 2017 •

edited by refack

Loading

vsemozhetbyt commented Aug 3, 2017 •

edited

Loading

vsemozhetbyt commented Aug 4, 2017 •

edited

Loading