benchmark: Correct constructor for freelist #14627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to use current constructor for freelist, which was changed under pr #12644
nodejs-github-bot
added
the
benchmark
cjihrig
approved these changes
Aug 4, 2017
lpinca
approved these changes
Aug 4, 2017
jasnell
approved these changes
Aug 4, 2017
gibfahn
approved these changes
Aug 5, 2017
addaleax
approved these changes
Aug 10, 2017
|
Landed in b5556e4, thank you! |
addaleax
pushed a commit
that referenced
this pull request
Aug 10, 2017
Updates to use current constructor for freelist, which was changed under pr #12644 Ref: #12644 PR-URL: #14627 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Aug 12, 2017
Updates to use current constructor for freelist, which was changed under pr #12644 Ref: #12644 PR-URL: #14627 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to use current constructor for freelist, which was changed
under pr #12644.
While setting up core benchmark tests in jenkins, i came across this benchmark that currently is broken in master.
This fixes the benchmark (functionally).
Checklist
Affected core subsystem(s)
benchmark