tools: checkout for unassigned DEP00XX codes #14702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
addaleax
approved these changes
Aug 8, 2017
doc/releases.md
Outdated
| If this release includes any new deprecations it is necessary to ensure that | ||
| those are assigned a proper static deprecation code. These are listed in the | ||
| docs (see `doc/api/deprecations.md`) and in the source as `DEP00XX`. The code | ||
| must be assigned a number (e.g. `DEP0012`). |
There was a problem hiding this comment.
We should probably mention that usually assigning deprecation codes should happen while landing?
There was a problem hiding this comment.
Yes, they should be made before landing, otherwise we could end up with nightlies that contain invalid/duplicate deprecation codes if we wait until the next release.
tniessen
approved these changes
Aug 9, 2017
Check for `DEP00XX` codes on release build like we do with `REPLACEME`
jasnell
added a commit
that referenced
this pull request
Aug 16, 2017
Check for `DEP00XX` codes on release build like we do with `REPLACEME` PR-URL: #14702 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in eac0147 |
MSLaguana
pushed a commit
to nodejs/node-chakracore
that referenced
this pull request
Aug 21, 2017
Check for `DEP00XX` codes on release build like we do with `REPLACEME` PR-URL: nodejs/node#14702 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Check for `DEP00XX` codes on release build like we do with `REPLACEME` PR-URL: #14702 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
|
I don't believe this is applicable to v6.x. LMK if it should land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for
DEP00XXcodes on release build like we do withREPLACEMEChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools