http: be more specific when reporting errors #14759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reporting header content errors specify header name in the message for easier debugging in user applications. Fix: nodejs#14754
mscdex
added
the
semver-major
|
How about more simply: |
|
@mscdex I don't mind. Although, both are consistent with existing error messages. |
jasnell
reviewed
Aug 11, 2017
| @@ -440,7 +440,8 @@ function storeHeader(self, state, key, value, validate) { | |||
| throw new Error('Header "%s" value must not be undefined', key); | |||
| } else if (checkInvalidHeaderChar(value)) { | |||
| debug('Header "%s" contains invalid characters', key); | |||
| throw new TypeError('The header content contains invalid characters'); | |||
| throw new TypeError( | |||
| 'The header content contains invalid characters ["' + key + '"]'); | |||
There was a problem hiding this comment.
If the error messages are being changed, it would be nice to migrate the files to use internal/errors at the same time.
jasnell
approved these changes
Aug 11, 2017
cjihrig
approved these changes
Aug 11, 2017
lpinca
approved these changes
Aug 11, 2017
evanlucas
approved these changes
Aug 11, 2017
|
The errors in |
|
@indutny ... can you give this a rebase? |
|
It appears your're right :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reporting header content errors specify header name in the message
for easier debugging in user applications.
Fix: #14754
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http