lib: instantiate console methods eagerly #14791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
cjihrig
approved these changes
Aug 12, 2017
TimothyGu
approved these changes
Aug 12, 2017
TimothyGu
reviewed
Aug 12, 2017
lib/internal/bootstrap_node.js
Outdated
| global.console.log; | ||
| global.console.time; | ||
| global.console.timeEnd; | ||
| global.console.trace; |
There was a problem hiding this comment.
What about other console methods though, like console.warn etc.?
There was a problem hiding this comment.
They're aliases for (e.g.) console.error.
There was a problem hiding this comment.
how about the new ones like console.count(), console.countReset() and console.clear()? Are those needed here also?
There was a problem hiding this comment.
seems like console.dir() should be included here as well as it's not an alias?
There was a problem hiding this comment.
Good point about console.dir(). The others seem less important but I've added them too.
refack
approved these changes
Aug 13, 2017
tniessen
approved these changes
Aug 14, 2017
Before this commit they were instantiated lazily but that fails when the first call is under stack overflow conditions. Fixes: nodejs/help#778
bnoordhuis
force-pushed
the
fix-help-778
branch
from
a87cf22
to
70bbb10
Compare
|
Rebased + new CI: https://ci.nodejs.org/job/node-test-pull-request/9705/ |
jasnell
approved these changes
Aug 23, 2017
jasnell
pushed a commit
that referenced
this pull request
Aug 23, 2017
Before this commit they were instantiated lazily but that fails when the first call is under stack overflow conditions. PR-URL: #14791 Fixes: https://github.com/nodejs/help#778 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in da1af3d |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Aug 25, 2017
Before this commit they were instantiated lazily but that fails when the first call is under stack overflow conditions. PR-URL: nodejs/node#14791 Fixes: https://github.com/nodejs/help#778 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 28, 2017
Before this commit they were instantiated lazily but that fails when the first call is under stack overflow conditions. PR-URL: nodejs/node#14791 Fixes: https://github.com/nodejs/help#778 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Before this commit they were instantiated lazily but that fails when the first call is under stack overflow conditions. PR-URL: #14791 Fixes: https://github.com/nodejs/help#778 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Before this commit they were instantiated lazily but that fails when the first call is under stack overflow conditions. PR-URL: #14791 Fixes: https://github.com/nodejs/help#778 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Should this be backported to v6.x? If it is backported we will need to rewrite the test, as it relies on async / await |
|
@MylesBorins the test was actually removed again. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit they were instantiated lazily but that fails when the
first call is under stack overflow conditions.
Fixes: nodejs/help#778
CI: https://ci.nodejs.org/job/node-test-pull-request/9629/