test: add missing console.error to exec-maxBuffer #14796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the missing console.error to test-child-process-exec-maxBuffer
addaleax
approved these changes
Aug 12, 2017
vsemozhetbyt
approved these changes
Aug 12, 2017
vsemozhetbyt
added
the
child_process
|
CI: https://ci.nodejs.org/job/node-test-pull-request/9634/ EDIT(gibfahn): CI was green except for an ARM flake. |
DavidCai1111
approved these changes
Aug 13, 2017
cjihrig
approved these changes
Aug 13, 2017
Trott
approved these changes
Aug 13, 2017
|
Sure looks like an error on my part. Thanks for catching it and fixing it. |
aqrln
approved these changes
Aug 13, 2017
gibfahn
force-pushed
the
fix-child-process-exec-maxbuff
branch
from
86af084
to
bc43409
Compare
tniessen
approved these changes
Aug 16, 2017
|
Landed in 4f1eddf, thank you! 🎉 |
tniessen
pushed a commit
that referenced
this pull request
Aug 16, 2017
Adds the missing console.error to test-child-process-exec-maxBuffer PR-URL: #14796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MSLaguana
pushed a commit
to nodejs/node-chakracore
that referenced
this pull request
Aug 21, 2017
Adds the missing console.error to test-child-process-exec-maxBuffer PR-URL: nodejs/node#14796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Adds the missing console.error to test-child-process-exec-maxBuffer PR-URL: #14796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 20, 2017
Adds the missing console.error to test-child-process-exec-maxBuffer PR-URL: #14796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at this test I noticed that the final cmd calls
console.('${unicode}'). To me, it wasn't clear if this was intentional or if it should beconsole.error('${unicode}').https://github.com/nodejs/node/blob/master/test/parallel/test-child-process-exec-maxBuffer.js#L39
If it was intentional I am happy for this to be closed and/or I can add a comment to the test.
/cc @Trott as author of the test case
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test