Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor async-hooks/test-httparser tests #14818

Closed
wants to merge 2 commits into from
Closed

test: refactor async-hooks/test-httparser tests #14818

wants to merge 2 commits into from

Commits on Aug 14, 2017

  1. test: refactor async-hooks/test-httparser tests 

    CRLF variable was defined but only used on line 22 so the variable
was deleted and placed inside line 22 as a string literal. This
was in file test-httpparser.request.js

On line 46 there's a function declared that takes 3 arguments but
none of them are ever used so removed. This is in file
test-httpparser.response.js
    @Runite618
    Runite618 committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    a8655e7 View commit details
    Browse the repository at this point in the history

  2. test: refactor asyncs-hooks/test-httparser tests 

    Modification of the file test-httpparser.request.js to have the
string literals \r\n to be included in the string literal
of line 22 and not concatenated to remove errors and hopefully
pass the tests.
    @Runite618
    Runite618 committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    a9c22d9 View commit details
    Browse the repository at this point in the history