test: increase coverage for http2.connect #14832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added checks for connecting using https and an unsupported protocol.
addaleax
approved these changes
Aug 14, 2017
There was a problem hiding this comment.
LGTM
(Whitespace-adjusted diff: https://github.com/nodejs/node/pull/14832/files?w=1)
cjihrig
approved these changes
Aug 15, 2017
tniessen
approved these changes
Aug 15, 2017
lpinca
reviewed
Aug 15, 2017
| })); | ||
| // check for https as protocol | ||
| { | ||
| const authority = 'https://localhost'; |
There was a problem hiding this comment.
Is it safe to assume that there is no server listening on localhost?
There was a problem hiding this comment.
This seems to run fine with a server listening on localhost.
jasnell
approved these changes
Aug 16, 2017
hiroppy
approved these changes
Aug 16, 2017
|
Landed in aa24777, thank you! |
addaleax
pushed a commit
that referenced
this pull request
Aug 21, 2017
Added checks for connecting using https and an unsupported protocol. PR-URL: #14832 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Added checks for connecting using https and an unsupported protocol. PR-URL: #14832 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Added checks for connecting using https and an unsupported protocol. PR-URL: #14832 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to check for
connectusing HTTPS working as intended andERR_HTTP2_UNSUPPORTED_PROTOCOLbeing thrown for using an unsupported protocol.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2