Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix a typo in doc/api/cli.md #14855

Closed
wants to merge 1 commit into from
Closed

doc: fix a typo in doc/api/cli.md #14855

wants to merge 1 commit into from

Conversation

hsmtkk
Copy link
Contributor

@hsmtkk hsmtkk commented Aug 16, 2017

Fix a typo in a document.

Checklist
  • documentation is changed or added
  • commit message follows [commit guidelines]
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Aug 16, 2017
vsemozhetbyt
vsemozhetbyt approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @hsmtkk!

@silverwind
Copy link
Contributor

Thanks! I Landed in 472a8a7.

@silverwind silverwind closed this Aug 16, 2017
silverwind pushed a commit that referenced this pull request Aug 16, 2017
@hsmtkk @silverwind
doc: fix typo in cli.md
472a8a7 
PR-URL: #14855
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Roman Reiss <me@silverwind.io>
@hsmtkk hsmtkk deleted the fixtypo branch August 16, 2017 19:41
MSLaguana pushed a commit to nodejs/node-chakracore that referenced this pull request Aug 21, 2017
@hsmtkk @MSLaguana
doc: fix typo in cli.md
69337a6 
PR-URL: nodejs/node#14855
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@hsmtkk @MylesBorins
doc: fix typo in cli.md
e09138e 
PR-URL: #14855
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@hsmtkk @MylesBorins
doc: fix typo in cli.md
c8f0e5a 
PR-URL: #14855
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzoz bzoz bzoz approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@tniessen tniessen tniessen approved these changes

@jasnell jasnell jasnell approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hsmtkk @silverwind @jasnell @tniessen @vsemozhetbyt @bzoz @MylesBorins @nodejs-github-bot