-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use invalid host according to RFC2606 #14863
Conversation
This could be used in more tests, for example |
@silverwind Are you referring to this part of the file? node/test/parallel/test-dns.js Lines 214 to 221 in 9cb390d
|
@lpinca yes, that's another example, but I was refering to the file in node/test/internet/test-dns.js Line 391 in 9cb390d
node/test/internet/test-dns.js Line 514 in 9cb390d
|
@silverwind I guess the comment was for @tniessen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Landed in 467385a. If you see any other occurrences which should be changed, feel free to comment here. |
PR-URL: #14863 Refs: #14781 Refs: https://tools.ietf.org/html/rfc2606#section-2 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This appears to rely on a semver-major change. setting |
Refs: #14781
Refs: https://tools.ietf.org/html/rfc2606#section-2
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test