util: use constructor name #14886
Closed
util: use constructor name #14886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
util
BridgeAR
commented
Aug 17, 2017
lib/util.js
Outdated
| } else if (Array.isArray(value)) { | ||
| if (constructor) | ||
| return ctx.stylize(`[${constructor.name}]`, 'special'); | ||
| if (Array.isArray(value)) |
There was a problem hiding this comment.
Note: this check is redundant as soon as #14881 has landed. Right now Arrays set the constructor to null and the check has to be done again.
BridgeAR
added
the
semver-major
jasnell
approved these changes
Aug 17, 2017
cjihrig
approved these changes
Aug 17, 2017
|
Commit message nit: doesn't this apply to objects that exceed the depth limit rather than circular objects? Or both? |
BridgeAR
force-pushed
the
add-proper-constructor
branch
from
d43d928 to
d76998e
Compare
|
@TimothyGu you are absolutely right! Fixed |
|
PTAL I changed the commit message and this could land otherwise. |
TimothyGu
approved these changes
Aug 24, 2017
hiroppy
approved these changes
Aug 26, 2017
|
I would like to land this after #14881 as that one would otherwise not cleanly land on 8.x. Otherwise I would have already landed that. Marking this as blocked because of that. |
When reaching the depth limit util.inspect always prints [Array] or [Object] no matter if it is a subclass or not. This fixes it by showing the actual constructor name instead.
BridgeAR
force-pushed
the
add-proper-constructor
branch
from
d76998e to
572f1ef
Compare
|
Rebased. PTAL, I would like to land this very soon. |
refack
approved these changes
Sep 19, 2017
|
Landed in b1c8f15 |
BridgeAR
added a commit
that referenced
this pull request
Sep 19, 2017
When reaching the depth limit util.inspect always prints [Array] or [Object] no matter if it is a subclass or not. This fixes it by showing the actual constructor name instead. PR-URL: #14886 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
When reaching the depth limit util.inspect always prints [Array] or [Object] no matter if it is a subclass or not. This fixes it by showing the actual constructor name instead. PR-URL: nodejs/node#14886 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
When reaching the depth limit util.inspect always prints [Array] or [Object] no matter if it is a subclass or not. This fixes it by showing the actual constructor name instead. PR-URL: nodejs/node#14886 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For circular references util.inspect always prints Array
or Object not matter if it is a subclass or not.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
util