Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: fix crash while setting server during query #14891

Closed
wants to merge 5 commits into from
Closed

dns: fix crash while setting server during query #14891

wants to merge 5 commits into from

Commits on Nov 15, 2017

  1. dns: fix crash while setting server during query 

    Fix this issue follow these two points:

1. Keep track of how many queries are currently open. If `setServers()`
   is called while there are open queries, error out.
2. For `Resolver` instances, use option 1. For dns.setServers(), just
   create a fresh new default channel every time it is called, and then
   set its servers list.

Fixes: nodejs#14734
    @XadillaX
    XadillaX committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    c3bb82a View commit details
    Browse the repository at this point in the history

  2. fix a typo

    @XadillaX
    XadillaX committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    3af0573 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2017

  1. update based on @addaleax' advise

    @XadillaX
    XadillaX committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    f7db3d6 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2017

  1. update after @BridgeAR's reviewing

    @XadillaX
    XadillaX committed Dec 6, 2017
    Configuration menu
    Copy the full SHA
    caab532 View commit details
    Browse the repository at this point in the history

  2. fix a lint nit

    @XadillaX
    XadillaX committed Dec 6, 2017
    Configuration menu
    Copy the full SHA
    ac04c85 View commit details
    Browse the repository at this point in the history