Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove extra copy from Copy() in node_url.cc #14907

Closed
wants to merge 1 commit into from
Closed

src: remove extra copy from Copy() in node_url.cc #14907

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

The was copying the whole array and the strings in it without any benefit.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/node_url.cc

@addaleax
src: remove extra copy from Copy() in node_url.cc
fe9c0e8 
The was copying the whole array and the strings in it without
any benefit.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Aug 18, 2017
@TimothyGu
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/9726/

@addaleax
Copy link
Member Author

Landed in 6a0e3b1

@addaleax addaleax closed this Aug 21, 2017
@addaleax addaleax deleted the take-copying-less-seriously branch August 21, 2017 14:55
addaleax added a commit that referenced this pull request Aug 21, 2017
@addaleax
src: remove extra copy from Copy() in node_url.cc
6a0e3b1 
The was copying the whole array and the strings in it without
any benefit.

PR-URL: #14907
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@addaleax @MylesBorins
src: remove extra copy from Copy() in node_url.cc
e6965f0 
The was copying the whole array and the strings in it without
any benefit.

PR-URL: #14907
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@addaleax @MylesBorins
src: remove extra copy from Copy() in node_url.cc
4570fa1 
The was copying the whole array and the strings in it without
any benefit.

PR-URL: #14907
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @TimothyGu @jasnell @cjihrig @tniessen @nodejs-github-bot