Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update windows module load error message #14950

Merged
merged 1 commit into from
Aug 22, 2017
Merged

test: update windows module load error message #14950

merged 1 commit into from
Aug 22, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 20, 2017

libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message.

Refs: #14866
Refs: libuv/libuv#1116

cc: @bnoordhuis

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 20, 2017
richardlau
richardlau approved these changes Aug 20, 2017
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's possible that the libuv update gets backported to LTS then I wonder if it it would make it easier for @nodejs/lts if this was included in the libuv update PR but as a separate commit because they have to land together.

@gibfahn gibfahn mentioned this pull request Aug 20, 2017
Merged
2 tasks
@refack refack added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Aug 20, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 20, 2017

If it's possible that the libuv update gets backported to LTS then I wonder if it it would make it easier for @nodejs/lts if this was included in the libuv update PR but as a separate commit because they have to land together.

This commit is completely independent of the libuv update. However, the opposite is not true. There is no chance of the libuv update being backported without this, because the Windows CI will light up bright red. For that reason, I think it's fine to keep them as separate PRs.

Technically, this is an error message change, so it could be considered semver major. However, it comes from a dependency, so Node doesn't really have any control there.

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 22, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9780/

@cjihrig
test: update windows module load error message
9eb8f44 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: nodejs#14866
PR-URL: nodejs#14950
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 9eb8f44 into nodejs:master Aug 22, 2017
@cjihrig cjihrig deleted the load-err branch August 22, 2017 03:53
addaleax pushed a commit to addaleax/ayo that referenced this pull request Aug 25, 2017
@cjihrig @addaleax
test: update windows module load error message
dd29648 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: nodejs/node#14866
PR-URL: nodejs/node#14950
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Aug 28, 2017
@cjihrig @addaleax
test: update windows module load error message
40adc2c 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: nodejs/node#14866
PR-URL: nodejs/node#14950
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@cjihrig @MylesBorins
test: update windows module load error message
6263e01 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: #14866
PR-URL: #14950
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@cjihrig @MylesBorins
test: update windows module load error message
e244f84 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: #14866
PR-URL: #14950
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

this needs to land with #14866

MylesBorins pushed a commit that referenced this pull request Oct 16, 2017
@cjihrig @MylesBorins
test: update windows module load error message
eb2a0db 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: #14866
PR-URL: #14950
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@cjihrig @MylesBorins
test: update windows module load error message
4030c7e 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: #14866
PR-URL: #14950
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @MylesBorins @refack @jasnell @tniessen @richardlau @gibfahn @nodejs-github-bot