Update http2.md #14979
Closed
Update http2.md #14979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"require('http');" should be "require('http2');"
nodejs-github-bot
added
doc
addaleax
approved these changes
Aug 22, 2017
jasnell
approved these changes
Aug 22, 2017
|
This should not need to wait the full 48 hours to land |
lpinca
approved these changes
Aug 22, 2017
cjihrig
approved these changes
Aug 22, 2017
|
Landed in d70d36b |
lance
pushed a commit
that referenced
this pull request
Aug 22, 2017
`require('http');` should be `require('http2');`
PR-URL: #14979
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Aug 25, 2017
`require('http');` should be `require('http2');`
PR-URL: nodejs/node#14979
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 28, 2017
`require('http');` should be `require('http2');`
PR-URL: nodejs/node#14979
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
`require('http');` should be `require('http2');`
PR-URL: #14979
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
`require('http');` should be `require('http2');`
PR-URL: #14979
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"require('http');" should be "require('http2');"
Affected core subsystem(s)
doc
http2