Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: improve definition of a collaborator #14981

Closed
wants to merge 2 commits into from
Closed

meta: improve definition of a collaborator #14981

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2360df3
meta: improve definition of a collaborator
jasnell Aug 22, 2017
92d2951
squash: optional overhaul
Trott Aug 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions GOVERNANCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,17 @@ Committee (CTC) which is responsible for high-level guidance of the project.
The [nodejs/node](https://github.com/nodejs/node) GitHub repository is
maintained by Collaborators who are added by the CTC on an ongoing basis.

A Collaborator is defined as any individual having commit access to any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great clear statement, but it is in apparent contradiction with both the preceding sentence and the immediately following sentence. I'm a fan of trying to use terminology in an inclusive way, but this doc needs to be treated with considerable care.

respository in the Node.js GitHub Organization.

Individuals identified by the CTC as making significant and valuable
Copy link
Member

@gibfahn gibfahn Aug 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So all collaborators are approved by the CTC? Assuming collaborators will now roughly map to @nodejs/members, does this mean everyone who joins the org needs CTC approval? Even if they're joining CommComm for example?

Also is this the current process? If not it seems like something that could use more general members feedback.

The answer could totally be "this is a hard question, let's roll with this and improve it going forward".

EDIT: I think this is what @Trott said:

But the immediate next sentence of the doc says that Collaborators are selected by the CTC. Those folks are not selected by the CTC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"approval" does not necessarily mean implicit voting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but identified suggests it's an active thing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the original language and it is definitely lacking. Specific suggestions for improvement are welcome as I'm not sure what would be better

contributions are made Collaborators and given commit access to the project. If
you make a significant contribution and are not considered for commit access,
log an issue or contact a CTC member directly.
contributions across any Node.js repository may be made Collaborators and given
commit access to the project. Consideration should be given to more than just
code commits and pull requests. Responding to issues, contributing to
documentation, work on the website and various community efforts should be
considered as well. If individuals making such contributions do not believe
they have been considered for commit access, they may log an issue or contact a
CTC member directly.

Modifications of the contents of the nodejs/node repository are made on
a collaborative basis. Anybody with a GitHub account may propose a
Expand Down