Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: improve test coverage #15105

Closed
wants to merge 3 commits into from
Closed

http2: improve test coverage #15105

wants to merge 3 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 30, 2017

Few small new tests to help improve http2 test coverage

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 30, 2017
@jasnell jasnell added the http2 Issues or PRs related to the http2 subsystem. label Aug 30, 2017
@jasnell
Copy link
Member Author

jasnell commented Sep 1, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9917/

@jasnell
Copy link
Member Author

jasnell commented Sep 5, 2017

CI failures are unrelated.

jasnell added a commit that referenced this pull request Sep 5, 2017
@jasnell
test: http2 test coverage for updateOptionsBuffer
425ce52 
PR-URL: #15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell added a commit that referenced this pull request Sep 5, 2017
@jasnell
test: http2 test coverage for assertValidPseudoHeader
2f9d9e5 
PR-URL: #15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell added a commit that referenced this pull request Sep 5, 2017
@jasnell
test: http2 test coverage for NghttpError
fd9d288 
small test verifying that the NghttpError is as expected

PR-URL: #15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Sep 5, 2017

Landed in 425ce52, 2f9d9e5 and fd9d288

@jasnell jasnell closed this Sep 5, 2017
@refack
Copy link
Contributor

refack commented Sep 6, 2017

@Horbi did you actually have a comment to leave? I've seen you do that on several other issues as well?

MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@jasnell @MylesBorins
test: http2 test coverage for updateOptionsBuffer
567c280 
PR-URL: #15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@jasnell @MylesBorins
test: http2 test coverage for assertValidPseudoHeader
f258002 
PR-URL: #15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@jasnell @MylesBorins
test: http2 test coverage for NghttpError
04d2ff0 
small test verifying that the NghttpError is as expected

PR-URL: #15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 11, 2017
@jasnell @MylesBorins
test: http2 test coverage for updateOptionsBuffer
1987967 
PR-URL: #15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 11, 2017
@jasnell @MylesBorins
test: http2 test coverage for assertValidPseudoHeader
a3aac48 
PR-URL: #15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 11, 2017
@jasnell @MylesBorins
test: http2 test coverage for NghttpError
a14c500 
small test verifying that the NghttpError is as expected

PR-URL: #15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@jasnell @MylesBorins
test: http2 test coverage for updateOptionsBuffer
837c29c 
PR-URL: #15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@jasnell @MylesBorins
test: http2 test coverage for assertValidPseudoHeader
c0dba0f 
PR-URL: #15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@jasnell @MylesBorins
test: http2 test coverage for NghttpError
9f79bd8 
small test verifying that the NghttpError is as expected

PR-URL: #15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@jasnell @addaleax
test: http2 test coverage for updateOptionsBuffer
ec6094e 
PR-URL: nodejs#15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@jasnell @addaleax
test: http2 test coverage for assertValidPseudoHeader
e874fcc 
PR-URL: nodejs#15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@jasnell @addaleax
test: http2 test coverage for NghttpError
c39e22d 
small test verifying that the NghttpError is as expected

PR-URL: nodejs#15105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jasnell @refack @danbev @benjamingr @lpinca @cjihrig @MylesBorins @nodejs-github-bot