-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove faulty test case #15110
Conversation
Ping @addaleax |
I would like to land this relatively soon. If there are no objections in the next two days, I would just go ahead and land this. |
PR-URL: nodejs#15110 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Landed in f154c83 |
PR-URL: nodejs#15110 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
PR-URL: #15110 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
@BridgeAR Can you use that explanation in the commit log next time, please? Rule of thumb: the log should explain what changed and why - not just what, that's usually easy enough to divine from the diff. |
@bnoordhuis will definitely do. I agree that this would help. |
While working on #14881 the test added in da1af3d started to fail for me. So I digged into that and realized that the output is not coming from the console.log in the catch part but from "somewhere". When applying the following patch it will print something different then expected.
When adding a
console.log()
orprocess.stdout.write("")
before the test it will not print"e"
either butSo the test is not working as anticipated and I removed it so #14881 can land.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test