deps: update http_parser to 2.5.0 #1517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running benchmarks on the Digital Ocean server... (Makes me wonder if Digital Ocean could sponsor a server for benchmarks for us... :) ) |
|
Ppppklmyppllllygyptp
|
|
@santigimeno cat over the keyboard? |
|
Maybe they are suggesting another test case input? ;-) LGTM. |
|
@indutny sorry about that. My kid was playing with the phone |
|
Benchmark results: https://gist.github.com/indutny/f4aef68005a0242a937e . Unfortunately, did it in reverse order so the Notable improvements:
Otherwise appears to be ambivalent. |
indutny
added a commit
that referenced
this pull request
Apr 24, 2015
PR-URL: #1517 Reviewed-By: Brian White <mscdex@mscdex.net>
|
Landed in b3a7da1, thank you! |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Apr 29, 2015
PR-URL: nodejs#1517 Reviewed-By: Brian White <mscdex@mscdex.net>
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Apr 30, 2015
PR-URL: nodejs#1517 PORT-PR-URL: nodejs#1559 Reviewed-By: Brian White <mscdex@mscdex.net>
This was referenced Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@bnoordhuis
R=@mscdex