Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken openssl links #15182

Closed
wants to merge 2 commits into from
Closed

Fix broken openssl links #15182

wants to merge 2 commits into from

Conversation

kasicka
Copy link

@kasicka kasicka commented Sep 4, 2017

Found dead link in doc, seems fixed in later releases.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. v4.x labels Sep 4, 2017
@targos
Copy link
Member

targos commented Sep 4, 2017

There are probably other dead links. It was fixed in #9338 which was not backported to v4.x.
/cc @nodejs/lts

@kasicka kasicka changed the title Fix dead link to SPKAC Fix broken openssl links Sep 4, 2017
@kasicka
Copy link
Author

kasicka commented Sep 4, 2017

Fixed other links I found.

silverwind
silverwind approved these changes Sep 8, 2017
View reviewed changes
Copy link
Contributor

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of versions in links, but I guess we can't really do anything about it.

@silverwind silverwind mentioned this pull request Sep 8, 2017
Closed
MylesBorins pushed a commit that referenced this pull request Sep 19, 2017
@MylesBorins
docs: Fix broken links in crypto.md
fc6145f 
PR-URL: #15182
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins
Copy link
Contributor

landed in fc6145f

@MylesBorins MylesBorins mentioned this pull request Sep 20, 2017
Closed
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@MylesBorins
docs: Fix broken links in crypto.md
43bbfaf 
PR-URL: #15182
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 25, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@danbev danbev danbev approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kasicka @targos @MylesBorins @silverwind @danbev @lpinca @cjihrig @nodejs-github-bot