test, build: Clean up package-lock.json after make coverage #15196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
ssbrewster
force-pushed
the
coverage-clean-pkg-lock
branch
from
13edb66
to
a3381a3
Compare
ssbrewster
changed the title
cjihrig
approved these changes
Sep 5, 2017
jasnell
approved these changes
Sep 5, 2017
|
Isn't better to use the |
|
Yeah I think |
|
Actually, relatedly, since |
When running make coverage npm installs istanbul-merge and nyc and generates a package-lock.json file Ensure this file is removed when running make coverage-clean Refs: https://github.com/nodejs/node/pull/15190/files#r136932786
Use these flags when running make coverage so that a package-lock.json file is not generated and npm does not attempt to save the deps to a non-existent package.json file Refs: https://github.com/nodejs/node/pull/15190/files#r136932786
ssbrewster
force-pushed
the
coverage-clean-pkg-lock
branch
from
a3381a3
to
39846c1
Compare
|
Thanks for mentioning those flags @lpinca @Fishrock123. PR updated. |
lpinca
approved these changes
Sep 6, 2017
TimothyGu
approved these changes
Sep 7, 2017
BridgeAR
approved these changes
Sep 8, 2017
|
@ssbrewster thanks a lot for your contribution! Landed in 9168b8c |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 8, 2017
Use these flags when running make coverage so that a package-lock.json file is not generated and npm does not attempt to save the deps to a non-existent package.json file. PR-URL: #15196 Refs: https://github.com/nodejs/node/pull/15190/files#r136932786 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Use these flags when running make coverage so that a package-lock.json file is not generated and npm does not attempt to save the deps to a non-existent package.json file. PR-URL: #15196 Refs: https://github.com/nodejs/node/pull/15190/files#r136932786 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 11, 2017
Use these flags when running make coverage so that a package-lock.json file is not generated and npm does not attempt to save the deps to a non-existent package.json file. PR-URL: #15196 Refs: https://github.com/nodejs/node/pull/15190/files#r136932786 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Use these flags when running make coverage so that a package-lock.json file is not generated and npm does not attempt to save the deps to a non-existent package.json file. PR-URL: #15196 Refs: https://github.com/nodejs/node/pull/15190/files#r136932786 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
Use these flags when running make coverage so that a package-lock.json file is not generated and npm does not attempt to save the deps to a non-existent package.json file. PR-URL: nodejs#15196 Refs: https://github.com/nodejs/node/pull/15190/files#r136932786 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Should this be backported to |
|
@MylesBorins what is the criteria for backporting? Happy to raise a PR if needed. |
|
I actually realized you asked another thing, sorry. I see no coverage target on v6.x Makefile so I think this should not be backported. |
|
Ok thanks for the confirmation @lpinca 😄 |
|
Added |
|
No worries @lpinca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
make coverage, npm installsistanbul-mergeandnycandgenerates a
package-lock.jsonfile.This PR adds the
rm package-lock.jsoncommand to the Makefile.Refs: https://github.com/nodejs/node/pull/15190/files#r136932786
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test